fix: address Copilot review findings on LinkedIn release publishing - #199
Merged
Conversation
- truncate() and truncate_little_text() could exceed the requested limit when limit <= 3, since they always appended "...". Both now hard-cap without the ellipsis for very small limits. - The Telegram notify job in publish-linkedin-release-shared.yml ran whenever telegram-chat-id was set, even without telegram-bot-token, which failed at runtime. A check-token step now gates both notify steps on the secret actually being present. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #194, addressing two findings from Copilot's review that were merged before being fixed:
truncate()/truncate_little_text()inprepare-linkedin-release-post/prepare.pycould exceed the requested limit whenlimit <= 3because they always appended.... Both now hard-cap without the ellipsis for very small limits.notifyjob inpublish-linkedin-release-shared.ymlran whenevertelegram-chat-idwas set, even iftelegram-bot-tokenwas omitted, which fails at runtime sincesend-telegram-messagerequires the token. Sincesecretsisn't available in reusable-workflowif:conditions (job or step level, per actionlint), acheck-tokenstep now resolves presence viaenv:/run:into a step output that gates both notify steps.Test plan
python3 -m pytest test/hooks/actionlint.sh .github/workflows/publish-linkedin-release-shared.ymlyamllint -c config/yamllint.yml .github/workflows/publish-linkedin-release-shared.yml